Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detailed HVAC setpoints (GEB), try 3 #931

Open
wants to merge 35 commits into
base: resstock-args-refactor
Choose a base branch
from
Open

Detailed HVAC setpoints (GEB), try 3 #931

wants to merge 35 commits into from

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented May 13, 2022 •
edited
Loading

Pull Request Description

Closes #852.

image

  building_type base feature diff % diff
report_simulation_output.end_use_electricity_cooling_m_btu MF 618.41 617.65 -0.76 -0.12
report_simulation_output.end_use_electricity_heating_m_btu MF 202.6 204.26 1.67 0.82
report_simulation_output.end_use_natural_gas_heating_m_btu MF 647.27 639.23 -8.04 -1.24
report_simulation_output.end_use_electricity_cooling_m_btu SFA 62.12 63.77 1.65 2.66
report_simulation_output.end_use_electricity_heating_m_btu SFA 154.16 152.82 -1.34 -0.87
report_simulation_output.end_use_natural_gas_heating_m_btu SFA 67.26 53.76 -13.49 -20.06
report_simulation_output.end_use_electricity_cooling_m_btu SFD 2450.58 2405.54 -45.04 -1.84
report_simulation_output.end_use_electricity_heating_m_btu SFD 1113.58 1131.66 18.07 1.62
report_simulation_output.end_use_natural_gas_heating_m_btu SFD 12703.03 12925.25 222.23 1.75

Base vs Feature Examples (project_national, n_samples=250)

Building Heating Setpoint Cooling Setpoint Heating Setpoint Has Offset Cooling Setpoint Has Offset Heating Setpoint Offset Magnitude Cooling Setpoint Offset Magnitude Heating Setpoint Offset Period Cooling Setpoint Offset Period
8 67F 76F Yes Yes 6F 2F Night +3h Night Setback -5h
9 70F 70F Yes Yes 3F 2F Night -1h Day Setup -5h

Building=8

image
image

Building=9

image
image

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

@joseph-robertson joseph-robertson added this to the ResStock v2.6.0 Beta milestone May 13, 2022
@joseph-robertson joseph-robertson self-assigned this May 13, 2022
joseph-robertson and others added 26 commits May 13, 2022 16:11
@joseph-robertson
Retrieve the generated schedules.
6086f61
@joseph-robertson
Initialize new hash.
433eb34
Latest results.
5f1d3fc
@joseph-robertson
Update os-hpxml to export sleep schedule.
4847d8a
@joseph-robertson
Update meta and server dir cleanup measures.
a5460ac
@joseph-robertson
First cut at exporting new setpoint schedules.
56ceb5d
@joseph-robertson
Reorganize meta measures a bit.
4ee9165
@joseph-robertson
Typo.
3658afb
@joseph-robertson
Merge branch 'resstock-args-refactor' into detailed-hvac-setpoints-3
e203121
@joseph-robertson
Merge conflicts.
6d74258
@joseph-robertson
Use deadband averaging approach.
83bf869
@joseph-robertson
Merge branch 'resstock-args-refactor' into detailed-hvac-setpoints-3
c32d13d
@joseph-robertson
Remove fixme.
2127744
@joseph-robertson
Catch no hvac control.
6854bd0
@joseph-robertson
Optionally skip measure before reading occupancy schedules.
53bd63b
@joseph-robertson
Temp check output.
8f4837e
@joseph-robertson
More temp debug statements.
a5ab98f
@joseph-robertson
Use a shared method for getting epw path.
fb1f470
@joseph-robertson
Missed an update.
bae9769
Latest results.
fd6dfbe
@joseph-robertson
Pull in upstream sleep schedule changes.
dee3854
@joseph-robertson
Few updates.
05d75f9
@joseph-robertson
Fix setpoints for smooth occupancy schedules.
0b4e86e
@joseph-robertson
Use old setpoint tsv files.
33aeac6
Latest results.
a3c0098
@joseph-robertson
Merge branch 'resstock-args-refactor' into detailed-hvac-setpoints-3
caa71ae
@joseph-robertson joseph-robertson marked this pull request as ready for review June 6, 2022 15:52
@joseph-robertson joseph-robertson mentioned this pull request Nov 4, 2022
Open
5 tasks
@joseph-robertson joseph-robertson linked an issue Nov 4, 2022 that may be closed by this pull request
Detailed HVAC setpoints (GEB) #852
Open
2 tasks
@joseph-robertson joseph-robertson mentioned this pull request Nov 17, 2022
Open
@joseph-robertson joseph-robertson removed this from the ResStock v3.1.0 milestone May 12, 2023
@shorowit shorowit mentioned this pull request May 18, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joseph-robertson joseph-robertson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detailed HVAC setpoints (GEB)
1 participant
@joseph-robertson